Use crosstestimpl.T in PF Configure cross-test
#2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizing on `crosstestimpl.T`: 1. Unifies the API across cross-tests 2. Makes it possible to use `Configure` in rapid tests 3. Simplifies the implementation of cross-tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2583 +/- ##
=======================================
Coverage 62.83% 62.84%
=======================================
Files 385 385
Lines 51653 51644 -9
=======================================
- Hits 32456 32454 -2
+ Misses 17373 17370 -3
+ Partials 1824 1820 -4 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Nov 4, 2024
VenelinMartinov
added a commit
that referenced
this pull request
Nov 5, 2024
Redoing #2583 on top of the existing PR stack in the area. The `crosstestimpl.T` interface is compatible with both `testing.T` and `rapid.T`, allowing us to use cross-tests in rapid property-based tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizing on
crosstestimpl.T:Configurein rapid testsI had intended to do this for a little while, #2578 reminded me. Sorry for the additional disruption.