Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Diff tests for secrets #2642

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 20, 2024

This change adds tests for PF handling of secrets in previews.

This covers:

  • secret attributes
  • secrets elements in set attributes,
  • secret collection attributes
  • secrets properties in blocks
  • secret blocks
  • secrets coming from pulumi schema

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (bef446f) to head (ad7f844).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2642   +/-   ##
=======================================
  Coverage   69.97%   69.97%           
=======================================
  Files         367      367           
  Lines       44503    44503           
=======================================
+ Hits        31140    31141    +1     
- Misses      11734    11735    +1     
+ Partials     1629     1627    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_cross_tests_for_sets_with_defaults branch from 02d9ef9 to 5fbeb0c Compare November 20, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_tests_for_secrets branch from 65f21fc to bfdda83 Compare November 20, 2024 17:42
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_cross_tests_for_sets_with_defaults branch from 5fbeb0c to 356abe6 Compare November 20, 2024 19:18
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_tests_for_secrets branch from bfdda83 to ad7f844 Compare November 20, 2024 19:18
Base automatically changed from vvm/pf_cross_tests_for_sets_with_defaults to master November 20, 2024 20:12
@VenelinMartinov VenelinMartinov merged commit eb08aa8 into master Nov 21, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_diff_tests_for_secrets branch November 21, 2024 10:51
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.96.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants