Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detailed diff handle secrets and outputs #2643

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 20, 2024

This change adds secret and output handling to the detailed diff v2 code. Secrets and outputs are not necessary for the algorithm so we just strip both from the inputs.

fixes #2526
fixes #2651

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (264a002) to head (64d59f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
+ Coverage   69.43%   69.45%   +0.01%     
==========================================
  Files         301      301              
  Lines       38613    38626      +13     
==========================================
+ Hits        26811    26827      +16     
+ Misses      10277    10275       -2     
+ Partials     1525     1524       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 5a9f4e0 to 0c77fff Compare November 21, 2024 13:04
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 0c77fff to fb364c0 Compare November 21, 2024 14:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from fb364c0 to 8965216 Compare November 21, 2024 14:41
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 8965216 to ede0755 Compare November 22, 2024 12:08
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from ede0755 to 3d3d520 Compare November 22, 2024 17:41
@VenelinMartinov VenelinMartinov changed the base branch from vvm/pf_detailed_diff1 to vvm/pf_accurate_previews_feature_flag November 22, 2024 18:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 3d3d520 to 1ef66c3 Compare November 22, 2024 18:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 7203921 to cf4362c Compare November 25, 2024 12:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 318058f to f354cdb Compare November 25, 2024 12:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from cf4362c to f86a647 Compare November 25, 2024 13:10
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from f354cdb to 8a0f428 Compare November 25, 2024 13:10
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from f86a647 to 0268a08 Compare November 25, 2024 14:19
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 8a0f428 to 3291da2 Compare November 25, 2024 14:19
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 0268a08 to 4bea1d9 Compare November 25, 2024 15:24
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 7258b95 to ca0b7a2 Compare November 25, 2024 15:24
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_accurate_previews_feature_flag branch from 4bea1d9 to 2029b99 Compare November 25, 2024 16:51
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from ca0b7a2 to f7072ac Compare November 25, 2024 16:51
@VenelinMartinov VenelinMartinov marked this pull request as draft November 25, 2024 17:32
@VenelinMartinov VenelinMartinov marked this pull request as ready for review November 25, 2024 17:32
Base automatically changed from vvm/pf_accurate_previews_feature_flag to master November 25, 2024 17:43
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from f7072ac to a6a1abf Compare November 25, 2024 18:12
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 25, 2024 18:12
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from e1a6d27 to 64d59f8 Compare November 26, 2024 11:56
@VenelinMartinov VenelinMartinov merged commit 9319c4b into master Nov 26, 2024
31 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/detailed_diff_fix_secrets branch November 26, 2024 12:48
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF previews do not display changes to secret values Strip Output and secret types from detailed diff input
3 participants