Add property value transform for removing secrets and outputs #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 22, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2656 +/- ##
=======================================
Coverage 69.34% 69.35%
=======================================
Files 301 301
Lines 38546 38558 +12
=======================================
+ Hits 26730 26742 +12
Misses 10294 10294
Partials 1522 1522 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
iwahbe
approved these changes
Nov 22, 2024
| @@ -128,6 +128,22 @@ func RemoveSecrets(pv resource.PropertyValue) resource.PropertyValue { | |||
| return Transform(unsecret, pv) | |||
| } | |||
|
|
|||
| func RemoveSecretsAndOutputs(pv resource.PropertyValue) resource.PropertyValue { | |||
There was a problem hiding this comment.
Why are we removing secrets and outputs?
There was a problem hiding this comment.
The detailed diff algorithm does not care about secrets and outputs, so this allows us to not have to handle them in the code. Expanded on the explanation in the PR description.
Base automatically changed from
vvm/transform_pv_preserve_nil_arrays
to
master
November 22, 2024 19:17
VenelinMartinov
force-pushed
the
vvm/pv_tranform_for_removing_secrets_and_outputs
branch
from
f5786e2 to
fb926f8
Compare
VenelinMartinov
deleted the
vvm/pv_tranform_for_removing_secrets_and_outputs
branch
|
This PR has been shipped in release v3.97.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a propertyvalue Transform for removing secrets and outputs. This will be useful in the detailed diff algorithm where secrets and outputs are not relevant, since DetailedDiff only returns paths to properties. We will instead remove all secrets and inputs when passed to the algorithm so it doesn't have to handle them in the internals.