Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Diff cross-tests for long lists #2648

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 21, 2024

This adds a cross-tests for handling long lists in PF Diff. Our handling is suboptimal but note that TF also struggles with this when there is a replacement.

Related to #2647

@VenelinMartinov
Copy link
Contributor Author

@VenelinMartinov VenelinMartinov changed the title Tests for long lists PF Diff cross-tests for long lists Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.96%. Comparing base (30cb60a) to head (8553657).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2648      +/-   ##
==========================================
- Coverage   69.98%   69.96%   -0.02%     
==========================================
  Files         367      367              
  Lines       44504    44504              
==========================================
- Hits        31144    31139       -5     
- Misses      11732    11737       +5     
  Partials     1628     1628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 21, 2024 13:13
@VenelinMartinov VenelinMartinov merged commit c739e04 into master Nov 21, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_diff_test_long_list branch November 21, 2024 13:59
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.96.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants