Enable l1-builtin-info test #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/l1-builtin-info
branch
3 times, most recently
from
b206948
to
09c6472
Compare
Frassle
added
the
impact/no-changelog-required
Frassle
force-pushed
the
fraser/l1-builtin-info
branch
2 times, most recently
from
b0cfbbf
to
ba16090
Compare
lunaris
approved these changes
Nov 14, 2024
Yeh I'll have a fresh look today. Maybe sleeping on it will have helped. |
Frassle
force-pushed
the
fraser/l1-builtin-info
branch
from
ba16090
to
a79523a
Compare
|
Found the problem with caching, it was only if "compiler" option was set. Fixed to use directory caches and added a comment as to why we don't cache if compiler is set. |
lunaris
reviewed
Nov 14, 2024
| } | ||
| } | ||
|
|
||
| func (host *yamlLanguageHost) loadTemplate(directory string, compilerEnv []string) (*ast.TemplateDecl, syntax.Diagnostics, error) { | ||
| if host.template != nil && host.compiler == "" { | ||
| return host.template, host.diags, nil | ||
| // We can't cache comppiled templates because at the first point we call loadTemplate (in |
lunaris
reviewed
Nov 14, 2024
|
|
||
| return host.template, diags, nil | ||
| if host.compiler != "" { |
There was a problem hiding this comment.
Might be worth either adding a shouldCache method or even just a cache method that internalise this check/provide a single place we can document it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the l1-builtin-info test. As we're now running multiple templates with the same
yamlLanguageHostwe can't globally cache the template in loadTemplate anymore.Instead we cache by the program directory. For normal runs there will only be the one program directory, and for conformance test we know each program will be in its own unique directory.