Enable l1-output-string #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
commented
Nov 14, 2024
| @@ -1,9 +1,9 @@ | |||
| outputs: | |||
There was a problem hiding this comment.
Accidentally commit the broken version of this file in #673
Frassle
force-pushed
the
fraser/l1-output-string
branch
from
3bf5222
to
962a71a
Compare
lunaris
approved these changes
Nov 14, 2024
This required two fixes.
Firstly when reading in a literal string from PCL we need to re-escape
any `$${` escape sequences.
Secondly it's valid to have an empty string as a stack export. We fix
this by making sure empty strings from PCL write out as `""` rather than
nothing, as the latter caused the yaml runtime to think it was an
empty/null/missing key rather than an empty string.
Frassle
force-pushed
the
fraser/l1-output-string
branch
from
962a71a
to
add46b0
Compare
|
This PR has been shipped in release v1.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required two fixes.
Firstly when reading in a literal string from PCL we need to re-escape any
$${escape sequences.Secondly it's valid to have an empty string as a stack export. We fix this by making sure empty strings from PCL write out as
""rather than nothing, as the latter caused the yaml runtime to think it was an empty/null/missing key rather than an empty string.