Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubygems-update for ruby older than 2.3 for travis and gitlab-ci #171

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

Felixoid
Copy link
Contributor

After the upgrade of rubygems-update the travis and gitlab-ci jobs are broken with

# gem update --system
Updating rubygems-update
Fetching: rubygems-update-3.0.0.gem (100%)
ERROR:  Error installing rubygems-update:
    rubygems-update requires Ruby version >= 2.3.0.
ERROR:  While executing gem ... (Errno::ENOENT)
    No such file or directory @ dir_chdir - /usr/local/bundle/gems/rubygems-update-2.6.6
# ruby --version
ruby 2.1.9p490 (2016-03-30 revision 54437) [x86_64-linux]

This patch has fixed it with the installation of the latest compatible version.

@Felixoid
Copy link
Contributor Author

This PR is related to puppetlabs/pdk#609

@tphoney
Copy link
Contributor

tphoney commented Dec 19, 2018

thanks for the pr @Felixoid i am looking at testing this now.

@Felixoid
Copy link
Contributor Author

For check that it works you also could take a look on https://gitlab.com/felixoid/puppet-clickhouse/pipelines/40820481 and innogames/puppet-clickhouse#3

@pmcmaw pmcmaw merged commit 20af4c6 into puppetlabs:master Dec 20, 2018
@bmjen bmjen added the bug label Jan 22, 2019
SeanHood added a commit to SeanHood/puppet-ipa that referenced this pull request Feb 5, 2019
SeanHood added a commit to SeanHood/puppet-ipa that referenced this pull request Feb 5, 2019
* Specified the OS Name to fix .downcase test failiure
* Added puppetlabs/cron_core and puppetlabs/k5login_core to .fixtures.yml as these have been split out of the puppet-agent gem
* Fix rubygems-update for ruby older than 2.3: Borrowed fixes from: puppetlabs/pdk-templates#171
mattock pushed a commit to mattock/puppet-ipa that referenced this pull request Mar 27, 2019
* Specified the OS Name to fix .downcase test failiure
* Added puppetlabs/cron_core and puppetlabs/k5login_core to .fixtures.yml as these have been split out of the puppet-agent gem
* Fix rubygems-update for ruby older than 2.3: Borrowed fixes from: puppetlabs/pdk-templates#171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants