Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONT MERGE !!!(FM-7655) test of setting rubygem version #1865

Closed
wants to merge 1 commit into from

Conversation

tphoney
Copy link
Contributor

@tphoney tphoney commented Dec 19, 2018

No description provided.

@tphoney tphoney changed the title (FM-7655) test of setting rubygem version DONT MERGE !!!(FM-7655) test of setting rubygem version Dec 19, 2018
@ekohl
Copy link
Collaborator

ekohl commented Dec 19, 2018

In theforeman org I also saw failures. Is this to fix the issue with github_changelog_generator requiring ruby 2.2.2 despite not being needed in tests or do you see another issue? One difference is that we don't do a gem update --system in theforeman though. For comparison: https://travis-ci.org/theforeman/puppet-katello/builds/470122778

@tphoney
Copy link
Contributor Author

tphoney commented Dec 19, 2018

@ekohl i am testing out this change puppetlabs/pdk-templates#171 before i merge to pdk-templates master. I will then roll this out to all supported modules assuming everything looks good. the other test prs are puppetlabs/puppetlabs-motd#187 & puppetlabs/puppetlabs-mysql#1149

@ekohl
Copy link
Collaborator

ekohl commented Dec 19, 2018

Ah, looks like a different issue then though perhaps it's the same root cause.

@tphoney
Copy link
Contributor Author

tphoney commented Dec 19, 2018

we can likely clean up the travis before_install. but that is a major change before the christmas break. break being the operative word.

thanks for the eyes @ekohl 👍

@tphoney tphoney closed this Dec 20, 2018
@david22swan david22swan deleted the FM-7655 branch March 26, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants