(GH-223) .travis.yml does not deploy by default

[ghoneycutt]

Without this patch, the TravisCI configuration will be broken and add a
deployment section with the incorrect password and without documentation
to explain how to do deploys correctly.

[ghoneycutt]

Fixes #223

[rtib]

I'm okay with the idea of having deployment setup optional. But, I think the feature toggle is not really necessary.

How about this: drop the deploy config key and enable the deployment section if user and secure are set.
This:

• does not require any change for modules having deploy already in place
• reduces config_defaults.yml
• simplifies .sync.yml for enabling deploy by requiring unavoidable settings only
• keeps the .travis.yml.erb template still readable

BTW, the default setting user: puppet favours a single publisher. While I really appreciate Voxpupuli a lot, I think this setting is wrong at pdk-templates.

Look at ae4c4e6.

[ghoneycutt]

Good idea, though I don't know how to implement it.

[ghoneycutt]

@scotje could you please review

[rtib]

Good idea, though I don't know how to implement it.

Here is the example

[scotje]

I agree with the change suggested by @rtib. After that I'm +1 on merging this.