(IAC-1307) Add Spec tests to nightly and pr_test GHActions configs #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking this could do with some more intelligence and dynamic generation of job steps so we don't have to do another rollout when Puppet 5 is deprecated, making use of this change: puppetlabs/puppet_litmus#357 |
|
Rebased to see if it all works now |
|
|
2 tasks
This change adds a new workflow to run spec (unit) tests as a standalone manual job and as options to the 'Nightly' and 'PR' tests.
Disha-maker
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a new workflow to run spec (unit) tests as a
standalone manual job and as options to the 'Nightly' and 'PR'
tests.
Testing
puppetlabs-testingmodule - (DO-NOT-MERGE) (IAC-1307) Add spec tests to GHActions workflows puppetlabs-testing#352 (<-- also see here for an example of how this will look)Pre-requisites before merging
puppet-module-gemsversion1.0releasedGemfilebumped to usepuppet-module-gems ~> 1.0