Add dynamic agent collections to test matrix generation #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 7 7
Lines 846 846
=======================================
Hits 520 520
Misses 326 326 Continue to review full report at Codecov.
|
* Change version_requirement check to use Gem::Requirement instead of eval * use COLLECTION_TABLE.values instead of a loop * sort the resulting collections for deterministic run-order * add some comments to existing code * output a warning on regex match fail * allow no-space between op and ver
DavidS
force-pushed
the
dynamic_agent_collection
branch
from
e656249
to
8f6a172
Compare
carabasdaniel
approved these changes
Dec 11, 2020
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for
matrix_from_metadatato generate the agent collections portion of the test matrix from the module'smetadata.json. This way, modules that don't support certain Puppet versions won't have tests run against those versions.This supersedes #356.