Skip to content

Fix ruby 1.8 style hashes. #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jstraw
Copy link

@jstraw jstraw commented May 4, 2023

Depends on #627 for CI fixes

@jstraw jstraw requested a review from a team as a code owner May 4, 2023 18:00
@puppet-community-rangefinder
Copy link

kubeadm_init_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

kubeadm_join_flags is a function

Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jstraw jstraw marked this pull request as draft May 4, 2023 19:26
@binford2k
Copy link
Contributor

tests depend on #627 being resolved

@jstraw jstraw force-pushed the rubocop-linting-fixes-may4th branch from 5d12ac5 to 565bf33 Compare May 4, 2023 20:06
@jstraw
Copy link
Author

jstraw commented May 4, 2023

Per discussion in the hackathon channels, this has been force pushed back to just the rubocop fixes and updated description to note that it requires the CI fixes in #627 to merge first

@jstraw jstraw marked this pull request as ready for review May 4, 2023 20:07
@jordanbreen28
Copy link
Contributor

@jstraw #627 was merged in, can you resolve the conflicts and the tests should re-kick?
Thanks!

@jstraw jstraw force-pushed the rubocop-linting-fixes-may4th branch from 565bf33 to f48f4ae Compare June 12, 2023 15:03
@jstraw jstraw requested review from bastelfreak and deric as code owners June 12, 2023 15:03
jstraw added 2 commits June 15, 2023 14:02
@jordanbreen28 jordanbreen28 force-pushed the rubocop-linting-fixes-may4th branch from 3e6e9b6 to 0cf398b Compare June 15, 2023 13:02
@jordanbreen28
Copy link
Contributor

Hey @jstraw - noticed this PR has gone all messy due to the merge conflicts.
You able to get this back to working order? Or if easier, go ahead and open a fresh one, I'll aim to get that merged in straight away.

@jstraw
Copy link
Author

jstraw commented Jun 27, 2023

Changes were cherry picked in puppet 8 work.

@jstraw jstraw closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants