Skip to content

(CONT-914) - Address CI Failures #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

(CONT-914) - Address CI Failures #627

merged 1 commit into from
May 15, 2023

Conversation

jordanbreen28
Copy link
Contributor

@jordanbreen28 jordanbreen28 commented May 3, 2023 •
edited
Loading

Summary of changes:

  1. Updated deprecated herculesteam-augeasproviders_sysctl to puppet-augeasproviders_sysctl to resolve dependency cycle on install module step
  2. Pointed towards static cni-provider weave-demonset-k8s-1.11.yaml, (as per suggested comment here from weave) after cloud.weave.works was taken out of service.
  3. Updated legacy fact $::ipaddress to use the already presentfetch_ip_by_hostname method in spec_helper_acceptance_local.rb as GCP VMs include both an internal/external IP address which caused issues.
  4. Updated test manifest in spec/acceptance/kubernetes_spec.rb to reflect supported OS. Initially the manifest only matched redhat/debian, but we run our CI on Centos.
  5. Updated generated discovery token from kubetool from rsa (bug due to mismatch on key type, fixes puppet/kubetool:7.0.0 - bad discovery_token_hash #614) to pkey.

@jordanbreen28 jordanbreen28 self-assigned this May 3, 2023
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner May 3, 2023 10:00
@jordanbreen28 jordanbreen28 force-pushed the CONT-914-address_ci_failures branch 3 times, most recently from 3b2f50f to 8263e23 Compare May 4, 2023 14:56
@jstraw jstraw mentioned this pull request May 4, 2023
Closed
@jordanbreen28 jordanbreen28 force-pushed the CONT-914-address_ci_failures branch 15 times, most recently from 01b5870 to c8b8d6b Compare May 12, 2023 11:35
@jordanbreen28 jordanbreen28 force-pushed the CONT-914-address_ci_failures branch 8 times, most recently from 36fbb49 to 1f005fe Compare May 15, 2023 07:29
@jordanbreen28 jordanbreen28 force-pushed the CONT-914-address_ci_failures branch 3 times, most recently from 3e72961 to 8ae6235 Compare May 15, 2023 07:32
@jordanbreen28 jordanbreen28 force-pushed the CONT-914-address_ci_failures branch from 8ae6235 to 1871b5c Compare May 15, 2023 07:55
GSPatton
GSPatton approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@GSPatton GSPatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

LukasAud
LukasAud approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 6f8f866 into main May 15, 2023
@LukasAud LukasAud deleted the CONT-914-address_ci_failures branch May 15, 2023 13:09
@jordanbreen28 jordanbreen28 mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelnak chelnak chelnak approved these changes

@GSPatton GSPatton GSPatton approved these changes

@LukasAud LukasAud LukasAud approved these changes

Assignees

@jordanbreen28 jordanbreen28

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

puppet/kubetool:7.0.0 - bad discovery_token_hash
4 participants
@jordanbreen28 @chelnak @GSPatton @LukasAud