Make an actual backup script #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supercow thoughts on adding a retention parameter to the backup script? Like only keep 2 backups by default? Change how many backups exist for the database and if it is equal to the retention policy then delete the oldest backup before starting the new backup ( to minimize disk usage and probability of running out of disk space ). Thoughts? |
Prior to this commit, there was no backup script. After this commit, there is a backup script that will iterate through an array of database names to produce a script to backup each database. Using the defined type, you can backup an arbitrary set of databases on a different cron schedule.
Prior to this commit, a separate backup script was generated for each database. This commit replaces all of that with a single bash script that can backup an arbitrary list of databases.
Prior to this commit, the backup functionality was partially inside init.pp and partially in a defined type. After this commit, the backup functionality is in its own class pe_databases::backup.
Prior to this commit, we used ensure_resource because it was meant to be inside a defined type that may be specified more than once. Now the defined type is gone and backup is a class After this commit, we use file resources for clarity since the class should not be defined more than once.
npwalker
force-pushed
the
make_an_actual_backup_script
branch
from
88a8ca7 to
f567911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a backup script and changes the interface in the puppet code for backup. Previously there was a defined type for backups and now there is a class that accepts an Array[Hash] of databases and cron schedules that is looped over.