-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.x to master #346
Merged
ScottGarman
merged 13 commits into
puppetlabs:master
from
MikaelSmith:merge-1.x-to-master
Dec 10, 2018
Merged
Merge 1.x to master #346
ScottGarman
merged 13 commits into
puppetlabs:master
from
MikaelSmith:merge-1.x-to-master
Dec 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`source_permissions` is deprecated in puppet6; remove it and use the defaults to quiet warnings (The default permissions behavior in puppet 4, 5, and 6 is to use the puppet agent user and that user's default umask or DACL).
These tickets do not affect the apt provider.
The dist_tag variable was introduced as a workaround for PUP-5802/PUP-5025. These tickets were resolved two years ago, so the workaround is no longer necessary.
…rce-permissions (MODULES-7791) Remove deprecated source_permissions
Since activemq packages are currently only available in our legacy dependencies repo, install the legacy puppetlabs-release package.
…_activemq_from_legacy_deps_repo (maint) Use legacy dependencies repo for activemq
Acceptance tests are not yet compatible with beaker 4; specify beaker ~> 3 in the Gemfile instead of >= 3.
…-beaker (MODULES-8198) Use beaker ~> 3
(MODULES-7760) Remove dist_tag in install.pp for RHEL platforms
CLA signed by all contributors. |
yumrepo was removed from puppet 6 and is now bundled with AIO puppet-agents as the yumrepo_core module. The puppet 6 gem, however, cannot manage yumrepo resources out of the box; Adding yumrepo_core as a fixture allows spec tests to pass with the puppet gem at version 6+.
Any ETA on this ? |
…ate-specs (MODULES-8318) Update rspec-puppet, add yumrepo_core fixtures for puppet 6
I think this will need an update now that some new 1.x work has been merged |
MikaelSmith
force-pushed
the
merge-1.x-to-master
branch
from
December 10, 2018 19:21
8104133
to
4e55dff
Compare
Done. |
caseywilliams
approved these changes
Dec 10, 2018
ScottGarman
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.