Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Update to have version requirements in metadata.json #43

Closed
wants to merge 1 commit into from
Closed

Conversation

cyberious
Copy link
Contributor

No description provided.

@MikaelSmith
Copy link
Contributor

Technically it will run on 4.0.0, it just won't do anything.

"requirements": [
{
"name": "puppet",
"version_requirement": ">= 3.8.0 < 4.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this version requirement apply to the master that I would install this on to later upgrade my agents?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I'd just state >= 3.8.0 if so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, does it have an impact on acceptance testing, where the tests run puppet agent after upgrading?

@MikaelSmith
Copy link
Contributor

@mhaskel Any idea why the forge claims we have 7 warnings, when the lint run here doesn't say any?

https://forge.puppetlabs.com/puppetlabs/puppet_agent/scores

@MikaelSmith
Copy link
Contributor

ping @cyberious

@MikaelSmith
Copy link
Contributor

Closed in favor of #47.

@MikaelSmith MikaelSmith closed this Jul 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants