(maint) Fixes for Forge score #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MikaelSmith
commented
Jul 9, 2015
MikaelSmith
commented
- Add Puppet version requirement to metadata
- Use Forge 'Puppet Approved' Lint settings
added 2 commits
July 9, 2015 15:43
Without this the Forge compares against Puppet 3.7, which will fail to compile the module.
https://forge.puppetlabs.com/approved/criteria outlines lint settings used to score Forge modules. Use those settings and fix new lint warnings/errors. Nested loops seem to throw puppet-lint for a loop, so introduce a local variable to circumvent a bogus warning.
| @@ -12,7 +12,8 @@ | |||
| } | |||
|
|
|||
| # manage puppet.conf contents, using inifile module | |||
| ['master', 'agent', 'main'].each |$section| { | |||
| ['master', 'agent', 'main'].each |$loop_section| { | |||
| $section = $loop_section | |||
There was a problem hiding this comment.
Lint is dumb.
manifests/prepare/puppet_config.pp - WARNING: top-scope variable being used without an explicit namespace on line 29
manifests/prepare/puppet_config.pp - WARNING: top-scope variable being used without an explicit namespace on line 31
underscorgan
pushed a commit
that referenced
this pull request
Jul 9, 2015
…core (maint) Fixes for Forge score
| "requirements": [ | ||
| { | ||
| "name": "puppet", | ||
| "version_requirement": ">= 3.8.0" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.