Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-732) - implement `Run only when user is logged on #150

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner July 29, 2020 10:22
@puppet-community-rangefinder
Copy link

scheduled_task is a type

Breaking changes to this file MAY impact these 10 modules (near match):

This module is declared in 0 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #150 into master will decrease coverage by 0.34%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   95.31%   94.97%   -0.35%     
==========================================
  Files           6        6              
  Lines         833      835       +2     
==========================================
- Hits          794      793       -1     
- Misses         39       42       +3     
Impacted Files Coverage Δ
lib/puppet/type/scheduled_task.rb 92.85% <ø> (ø)
lib/puppet_x/puppetlabs/scheduled_task/task.rb 92.30% <66.66%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a184fd3...6c4c828. Read the comment docs.

Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment, otherwise LGTM

REFERENCE.md Outdated
@@ -66,6 +66,10 @@ Please also note that Puppet must be running as a privileged user
in order to manage `scheduled_task` resources. Running as an
unprivileged user will result in 'access denied' errors.

If a user is specified without an accompanying password the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If a user is specified without an accompanying password the
If a user is specified without an accompanying password, the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sanfrancrisko sanfrancrisko merged commit 83e981b into puppetlabs:master Jul 30, 2020
@david22swan david22swan deleted the IAC-732 branch August 26, 2020 07:40
sigv added a commit to sigv/puppetlabs-scheduled_task that referenced this pull request Mar 29, 2021
Since the enhancement intended to help sysadmins, pulled in as
puppetlabs#150: When not setting a password,
this is interpreted as "Run only when user is logged on".

When configuring a scheduled task to use a Group Managed Service Account
(gMSA) principal, there is no password to provide. The scheduler will
get the password automatically when properly configured, and should be
able to run the task even though the service account is not "logged on".
Otherwise, the Managed Service Account is never "logged on" so the task
does not run on expected schedule.

It does not seem viable to add a proper test case for this particular
situation without an AD domain configuration and a proper gMSA in place.
Without a correct gMSA, an error message stating "No mapping between
account names and security IDs was done" appears to be returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants