Switch parsejson() from PSON to JSON parsing

[seanmil]

The use of PSON is deprecated and mostly removed from Puppet.
Switch this function from using PSON to a real JSON parsing
library via the MultiJson helper in Puppet::Util::Json.

[puppet-community-rangefinder]

parsejson is a function

Breaking changes to this file MAY impact these 13 modules (near match):

• elastic-elasticsearch
• elasticsearch-elasticsearch
• npwalker-pe_code_manager_webhook
• jmkeyes-powerdns
• jmkeyes-kairosdb
• epflsti-quirks
• ape-elasticsearch
• covermymeds-bind
• prozeta-powerdns_recursor
• reidmv-change_risk
• broadinstitute-sentinelone_agent
• danmanners-proxmox_api
• puppet-elasticsearch

This module is declared in 318 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[david22swan]

@seanmil Apologies but could you provide some evidence regarding the said deprecation?
From what I can tell PSON is still included within the newest versions of puppet.

[chelnak]

Hey @seanmil, are you still interested in progressing with this Pull Request?

It looks like there is a question from @david22swan to address.

[seanmil]

Apologies but could you provide some evidence regarding the said deprecation?
From what I can tell PSON is still included within the newest versions of puppet.

@david22swan Sorry, I could have phrased that a lot better. What I meant was that unless I'm misremembering, back in the distant past everything in Puppet which used JSON used PSON instead, even if it was supposed to be real JSON and that using PSON instead of JSON for things which should be JSON has been not in favor for quite a while.

Regardless though, that is not really the point. The point is that the function name is "parsejson", but actually parses PSON, which doesn't parse all the JSON which the JSON functions will parse (see the updated spec examples).

If there is a desire/need for parsepson then that should be introduced as a separate function.

Thanks!

[david22swan]

LGTM

Logic behind this makes sense to me so I'm happy to merge. Have put up a PR to create a specific parsepson function:
#1259