File_line checks provided after param if no match is found #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| File.open(resource[:path], 'w') do |fh| | ||
| lines.each do |l| | ||
| fh.puts(regex.match(l) ? resource[:line] : l) | ||
| if (match_count == 0 and resource[:after]) |
There was a problem hiding this comment.
Want to use regex_after instead of resource[:after]?
There was a problem hiding this comment.
They would both logically be the same, nil or ! nil, just a matter of readability and preference I guess.
bmjen
force-pushed
the
file-line-refactor
branch
from
c56c13f
to
f016cb3
Compare
| :path => @tmpfile, | ||
| :line => 'inserted = line', | ||
| :after => after, | ||
| :match => match, |
There was a problem hiding this comment.
I know this is nitpicky, but the misalignment hurts my eyes. :(
Changed append line to open in 'w' mode and have to rewrite lines in order to append new line
bmjen
force-pushed
the
file-line-refactor
branch
from
f016cb3
to
0af0d7e
Compare
underscorgan
pushed a commit
that referenced
this pull request
Apr 9, 2015
File_line checks provided after param if no match is found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of PRs:
Closes #427
Closes #327
Closes #317
Refactor eliminates the need to rewrite the file twice.