parallel_spec_standalone: use --format progress #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 41.88% 41.82% -0.07%
==========================================
Files 10 10
Lines 678 679 +1
==========================================
Hits 284 284
- Misses 394 395 +1 ☔ View full report in Codecov by Sentry. |
bastelfreak
force-pushed
the
parallel
branch
2 times, most recently
from
71888ac
to
7b61bf2
Compare
bastelfreak
force-pushed
the
parallel
branch
2 times, most recently
from
9242b7a
to
d8f1389
Compare
ekohl
reviewed
Apr 9, 2024
For the past decade, people used a .rspec_parallel to configure this. We can set it directly in the rake task. That enables us to remove the .rspec_parallel and ultimately reduces the number of files required for pdk update/modulesync.
|
@bastelfreak 👋 dropping a note to say we aren't ignoring this. I'll update the thread again shortly. |
gavindidrichsen
approved these changes
May 9, 2024
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 9, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore.
bastelfreak
added a commit
to bastelfreak/puppetlabs_spec_helper
that referenced
this pull request
May 9, 2024
usually we've a .rspec file in every module: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb By moving this to the rake task we can delete the whole .rspec file. Similar to puppetlabs#446
bastelfreak
added a commit
to bastelfreak/puppetlabs_spec_helper
that referenced
this pull request
May 9, 2024
usually we've a .rspec file in every module: https://github.com/puppetlabs/pdk-templates/blob/main/moduleroot/.rspec.erb By moving this to the rake task we can delete the whole .rspec file. Similar to puppetlabs#446
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 9, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
bastelfreak
added a commit
to bastelfreak/modulesync_config
that referenced
this pull request
May 23, 2024
requires puppetlabs/puppetlabs_spec_helper#451 since puppetlabs/puppetlabs_spec_helper#446 the rake task configures the output so we don't need .rspec_parallel anymore. Requires also puppetlabs/puppetlabs_spec_helper#452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the past decade, people used a .rspec_parallel to configure this. We can set it directly in the rake task. That enables us to remove the .rspec_parallel and ultimately reduces the number of files required for pdk update/modulesync.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist