(RK-360) Allow overriding the cachedir in deploy module
#1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we added the ability to configure the cachedir from the CLI for the `deploy environment` command, since Code Manager configures a separate cachedir for each of its r10k workers. Now that we are also using the `deploy module` command in Code Manager, it needs to respect these special cachedirs the same way. The `--cachedir` flag can now be used with the `deploy module` command.
justinstoller
approved these changes
Jan 31, 2020
|
Yeah it was a little difficult to follow the thread of exactly where this gets plumed through. It winds up kicking in here mostly, I think. |
mwaggett
approved these changes
Jan 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added the ability to configure the cachedir from the CLI
for the
deploy environmentcommand, since Code Manager configures aseparate cachedir for each of its r10k workers. Now that we are also
using the
deploy modulecommand in Code Manager, it needs to respectthese special cachedirs the same way. The
--cachedirflag can now beused with the
deploy modulecommand.