Add R10K::CLI tests #952
Merged
Add R10K::CLI tests #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be a transient Travis build failure with jruby. Closing and re-opening to trigger rebuild. |
bastelfreak
approved these changes
Jan 20, 2020
|
hey people, can we get this merged/reviewed? |
adrienthebo
approved these changes
Apr 18, 2020
|
@dhollinger @justinstoller I've verified this locally, can one of you check out this PR as well? |
justinstoller
approved these changes
Apr 21, 2020
|
This appears to be causing failures when used with code-manger. One thing it does not appear to take into account is #1020, which we are using with a new feature to allow code-manager to do a deploy of a single module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests verify that each
Cricommand and option behaves as expected and sets options and args correctly within theActioninstances. Running the tests also showed that several of thedeployoptions were only valid in certain subcommands, so those options were moved into subcommands as appropriate. The other option would be to add support for those options in each of thedeploysubcommands.