Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outline and constituent properties. (Resolves #84, #85, #144.) #145

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Conversation

nsaunders
Copy link
Member

Description of the change

This change primarily adds support for outline, outline-style, outline-color, outline-width, and outline-offset. Unfortunately it supersedes #85 (which regrettably has sat unmerged for years), but hopefully it will be easy to understand why after reviewing the full scope of changes.

Aside from outline properties, the tests that I added (based on examples from MDN) revealed some missing type class instances (see #144).

Finally, I have begun implementing a different architecture for the test suite based on Clay. Hopefully this will make it easier in the future to "copy and paste" their tests if desired. 😉


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory todo (docs in general)
  • Added a test for the contribution (if applicable)

@nsaunders nsaunders merged commit 56fde10 into purescript-contrib:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant