Add outline CSS property #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is another PR that can be easily finished. |
|
Maybe we can just lift this https://github.com/sebastiaanvisser/clay/blob/16f55a5c6ab7fd98e39cedf852bd3400a02ac45f/src/Clay/Border.hs#L102-L144 EDIT We should be a bit more selective about which properties to support, however: sebastiaanvisser/clay#223 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just noticed it renders
"border: dashed 2.0px hsl(240.0, 100.0%, 50.0%) ".I mean: with a space at the end and I believe it should be
2pxinstead of2.0px.I'll create an issue to track this and try to address it in a separate PR ( #86 )
Actually, this is incomplete: we still need to be able to write things like
outline: noneResolves #84