Skip to content

Reverse direction of PropModifier composition #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maddie927 opened this issue Mar 5, 2020 · 1 comment
Closed

Reverse direction of PropModifier composition #135

maddie927 opened this issue Mar 5, 2020 · 1 comment

Comments

@maddie927
Copy link
Member

Current:

lumiElement qrcode
  <<< Border.border
  >>> Border._round
  >>> S.styleModifier_
      ( S.css
          { padding: S.int 16
          , width: S.int 140
          }
      )
  $ identity

Proposed:

lumiElement qrcode
  $ Border.border
  $ Border._round
  $ S.styleModifier_
      ( S.css
          { padding: S.int 16
          , width: S.int 140
          }
      )
  $ identity
@maddie927 maddie927 mentioned this issue Mar 5, 2020
Merged
This was referenced May 1, 2020
Closed
Merged
arthurxavierx added a commit that referenced this issue May 1, 2020
@arthurxavierx
[#135] Stop using parametric PropModifiers for styles and fix directi…
56a5526 
…on of style composition (#145)

* Add StyleModifier

* Rename styleModifier combinators

* Fix direction of composition of style modifiers

* Add combinators for using an array of styles as a prop modifier
@arthurxavierx
Copy link
Contributor

Fixed in #145; see this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maddie927 @arthurxavierx