[#135] Stop using parametric PropModifiers for styles and fix direction of style composition #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurxavierx
commented
Apr 30, 2020
|
|
||
| -- | Flatten a `PropsModifier` and extract the Emotion styles for use with `React.Basic.Emotion.element`. | ||
| -- | This function is mainly used inside component implementations where the `LumiComponent` boundary | ||
| -- | gives way to DOM components or other `ReactComponent`s. | ||
| toCSS :: | ||
| forall props. | ||
| PropsModifier () -> |
There was a problem hiding this comment.
@spicydonuts Since we're forcing the monomorphization of StyleModifier here we don't get any escaped skolem errors anymore :)
hdgarrood
approved these changes
Apr 30, 2020
arthurxavierx
commented
Apr 30, 2020
maddie927
approved these changes
Apr 30, 2020
kimispencer
approved these changes
Apr 30, 2020
kimispencer
approved these changes
Apr 30, 2020
arthurxavierx
changed the title
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 3 main effects:
StyleModifieralias, so that style modifiers cannot reference props anymore.styleModifierandstyleModifier_combinators to the less verbosestyleandstyle_.Now converting from style modifiers to Emotion's
Styletype is easy, since thetoCSSfunction now just directly converts anyStyleModifiertoLumiTheme -> Emotion.Style.