-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toMap and fromMap to Data.Set. - Retry #31
Conversation
Looks like this is good to merge now. I'd also be happy to see this convenience function added too, but that can be a separate PR. annotateSet :: forall a b. (a -> b) -> Set a -> Map a b
annotateSet f = mapWithIndex (\k _ -> f k) <<< toMap @np, feel free to rebase your original PR, or we can go with this one if that's more convenient. |
Looks good, but is the typelevel-prelude dependency being used at all? If not it should be removed from bower.json. |
According to CI, it's unnecessary. |
I'm good with this PR. 👍 for |
Assuming CI passes, we can merge this in. |
@milesfrain Sorry, but could you rebase this on top of current |
2758e41
to
2143543
Compare
Compressed history with a force push to make future rebases easier. Also noticed that Attempting to check CI on master with #40 |
CI now fails with MonadZero deprecation notices (easy to fix) and this error:
|
That error is because of a breaking change in an upstream dependency (namely quickcheck). I expect it was passing the last time we merged something. |
2143543
to
5c3e0a6
Compare
A rebased attempt at #21
Hopefully this works now with updated CI