Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci test - don't merge #40

Closed
wants to merge 2 commits into from
Closed

Conversation

milesfrain
Copy link
Contributor

Checking if CI still works on master

@milesfrain milesfrain marked this pull request as ready for review December 20, 2020 23:55
@milesfrain
Copy link
Contributor Author

Umm... how do I trigger CI for this PR?
Patience?

@JordanMartinez
Copy link
Contributor

Huh.... Is this because only the Readme was changed?

@milesfrain
Copy link
Contributor Author

Wow, I didn't expect CI to be language-aware, but that makes sense.
This might be an issue for the cookbook where we still want CI to run when editing the readme, although it would be even better to have different tests run depending on what types of files changed.

@hdgarrood
Copy link
Contributor

I think it’s probably a coincidence. Automatically inspecting a CI configuration file to figure out when CI can safely be skipped is basically impossible to do correctly, since the CI script can contain arbitrary commands.

@milesfrain milesfrain closed this Dec 21, 2020
@milesfrain milesfrain deleted the ci-test branch December 21, 2020 00:47
@thomashoneyman
Copy link
Member

thomashoneyman commented Dec 21, 2020

I don't know why it didn't run, but CI should run on any push or pull request against master regardless of what files are changed. There's no provision for README files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants