Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename spago bundle and spago make-module #147

Closed
f-f opened this issue Mar 16, 2019 · 4 comments · Fixed by #175
Closed

Rename spago bundle and spago make-module #147

f-f opened this issue Mar 16, 2019 · 4 comments · Fixed by #175
Milestone

Comments

@f-f
Copy link
Member

f-f commented Mar 16, 2019

These two commands do basically the same thing but have different enough names to be confusing.

So we should rename them to something clearer. Proposals:

  1. spago bundle-app, spago bundle-module
  2. spago bundle app spago bundle module
  3. spago bundle defaults to "app" mode, and the module functionality is behind a flag spago bundle --module
@f-f f-f added the RFC label Mar 16, 2019
@FintanH
Copy link
Contributor

FintanH commented Mar 16, 2019

My vote would be 2. 👍 👍

@FintanH
Copy link
Contributor

FintanH commented Mar 16, 2019

--main it to specify the main module that gets exposed (either to run or to export)

So I understand you're pointing to the --main module but it seems like a strange mnemonic to me for bundling a module. Does the module have to be a module Main?

@f-f
Copy link
Member Author

f-f commented Mar 16, 2019

@FintanH it doesn't have to be, but I hear you that this flag might be misnamed. If you do spago bundle --help, it gets a bit clearer as it tells you what it is for:

-m,--main MAIN           The main module to bundle

However, this same flag is --module in purs, so I'd support renaming it to --module here too

@FintanH
Copy link
Contributor

FintanH commented Mar 16, 2019

The main module to bundle

I think that's still ambiguous because it says "main" 😄

--module is good, my only gripe is that it's repetitive if we go down the route of spago bundle module. But I have no better alternative 👍

@f-f f-f added this to the 0.8 milestone Mar 17, 2019
Dretch added a commit to Dretch/spago that referenced this issue Apr 27, 2019
`spago bundle` => `spago bundle-app`
`spago make-module` => `spago bundle-module`
Dretch added a commit to Dretch/spago that referenced this issue Apr 27, 2019
`spago bundle` => `spago bundle-app`
`spago make-module` => `spago bundle-module`
@f-f f-f closed this as completed in #175 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants