Rename spago bundle and spago make-module (issue #147)
#175
Conversation
`spago bundle` => `spago bundle-app` `spago make-module` => `spago bundle-module`
There was a problem hiding this comment.
@Dretch thanks, looks great!
I agree on keeping the --main flag, as it's called the same in pulp too. However, let's get the flag description closer to the pulp one, which is:
--main -m <string> Module to be used as the application's entry point. [Default: "Main"]
Since you also updated the README I ticked the remaining points of the checklist. The only thing remaining to fix are the tests that fail for some reason.
I just realized that "how to run the tests" is not documented anywhere except for the CI file, so I'll add a CONTRIBUTING file.
But how I usually run the tests is: stack install && cd tests/spago-test/ && ../spago-test.py
|
@Dretch update on the tests: it looks like it was an issue with the caches on Travis, now everything seems to be fine |
|
Thanks @f-f -- I had run the tests locally using the command you suggested (which I figured out by looking at the Travis build). As you say, It would be helpful if this was clearer/easier. I will have a look at implementing the the other things you have mentioned. :) |
|
CI is not passing because the way we download dependencies is flaky. This should be fixed once and for all in #188, but this is good to merge |
* `spago bundle` => `spago bundle-app` * `spago make-module` => `spago bundle-module` * The old commands will error out with a suggestion to use the new ones
spago bundle=>spago bundle-appspago make-module=>spago bundle-moduleI used
bundle-appinstead ofbundle appfor consistency with the existing command structure - i.e. currently we havepsc-package-{local-setup,insdhall,clean}instead ofpsc-package {local-setup,insdhall,clean}.I also avoided changing
--mainto--modulebecause I don't have a view on what the best solution is there.PR checklist:
package.yamlaccording to SemVer (0.x.y.z,xchanges on breaking changes,yon additions,zon patches)READMEFix #147