Fix psc-package-clean and test cleanup on Windows #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces use of `Turtle.rmtree` with `System.Directory.removePathForcibly` to fix the following issues on Windows. `spago psc-package-clean` (and its test) fail because: 1. Git marks files under its /objects subdirectory as read-only 2. Turtle.rmtree fails to delete files marked as read-only So `rmtree` fails to remove any folder that's a git repository. As well as `psc-package-clean`, general test cleanup fails, meaning the test suite will fail completely when run for the second time.
|
Thanks! |
|
You're welcome 🙂 |
elliotdavies
pushed a commit
to elliotdavies/spago
that referenced
this pull request
Jul 1, 2019
Fix psc-package-clean and test cleanup on Windows Replaces use of `Turtle.rmtree` with `System.Directory.removePathForcibly` to fix the following issues on Windows. `spago psc-package-clean` (and its test) fail because: 1. Git marks files under its /objects subdirectory as read-only 2. Turtle.rmtree fails to delete files marked as read-only So `rmtree` fails to remove any folder that's a git repository. As well as `psc-package-clean`, general test cleanup fails, meaning the test suite will fail completely when run for the second time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Replaces use of
Turtle.rmtreewithSystem.Directory.removePathForciblyto fix the following issues on Windows.spago psc-package-clean(and its test) fail because:So
rmtreefails to remove any folder that's a git repository.As well as
psc-package-clean, general test cleanup fails, meaning the test suite will fail completely when run for the second time.Checklist: