Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psc-package-clean and test cleanup on Windows #224

Merged
merged 2 commits into from
May 30, 2019
Merged

Fix psc-package-clean and test cleanup on Windows #224

merged 2 commits into from
May 30, 2019

Commits on May 30, 2019

  1. AppVeyor: Enable psc-package tests (failing)

    @stkb
    stkb committed May 30, 2019
    Configuration menu
    Copy the full SHA
    db5eea1 View commit details
    Browse the repository at this point in the history

  2. Fix psc-package-clean and test cleanup on Windows 

    Replaces use of `Turtle.rmtree` with `System.Directory.removePathForcibly`
to fix the following issues on Windows.

`spago psc-package-clean` (and its test) fail because:
1. Git marks files under its /objects subdirectory as read-only
2. Turtle.rmtree fails to delete files marked as read-only

So `rmtree` fails to remove any folder that's a git repository.

As well as `psc-package-clean`, general test cleanup fails, meaning the
test suite will fail completely when run for the second time.
    @stkb
    stkb committed May 30, 2019
    Configuration menu
    Copy the full SHA
    dfa683e View commit details
    Browse the repository at this point in the history