tests: fix a tests that was breaking due to a phpunit issue

See related phpunit issue and PR : - sebastianbergmann/phpunit#2572 - sebastianbergmann/phpunit#2620
puzzle-org · Apr 4, 2017 · ebe0ecb · ebe0ecb
1 parent 3d84b50
commit ebe0ecb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
         "php" : ">=5.6"
     },
     "require-dev" : {
-        "phpunit/phpunit": "~5.7",
+        "phpunit/phpunit": "~5.7.18",
         "puzzle/configuration": "~3.0",
         "puzzle/assert": "~1.1"
     },

diff --git a/tests/JsonTest.php b/tests/JsonTest.php
@@ -78,13 +78,9 @@ public function providerTestJsonEncodeException()
         $recursionData[] = &$recursionData;
 
         return [
-            /**
-             *  Test working with phpunit ~4.8 but breaking with phpunit ~5.7 :
-             *  Fatal error: Maximum function nesting level of '256' reached, aborting! in phpunit/phpunit/src/Framework/TestCase.php on line 2442
-             */
-            // 'JSON_ERROR_RECURSION' => [
-            //     'data' => $recursionData,
-            // ],
+            'JSON_ERROR_RECURSION' => [
+                'data' => $recursionData,
+            ],
             'JSON_ERROR_INF_OR_NAN NAN' => [
                 'data' => NAN,
             ],