Bugfix: #2572 #2620
Closed
Bugfix: #2572 #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x/2572-support-autoreferenced-array-as-arguments-in-5.7
|
@sebastianbergmann Have you any idea what could be the issue that makes the test fail for php5.6? |
Codecov Report
@@ Coverage Diff @@
## 5.7 #2620 +/- ##
==========================================
+ Coverage 51.23% 52.24% +1%
+ Complexity 2906 2803 -103
==========================================
Files 110 106 -4
Lines 7065 6902 -163
==========================================
- Hits 3620 3606 -14
+ Misses 3445 3296 -149
Continue to review full report at Codecov.
|
|
Merged manually, thanks! |
This was referenced Apr 2, 2017
lebris
added a commit
to puzzle-org/pieces
that referenced
this pull request
Apr 4, 2017
See related phpunit issue and PR : - sebastianbergmann/phpunit#2572 - sebastianbergmann/phpunit#2620
Niktux
pushed a commit
to puzzle-org/pieces
that referenced
this pull request
Apr 4, 2017
See related phpunit issue and PR : - sebastianbergmann/phpunit#2572 - sebastianbergmann/phpunit#2620
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support autoreferenced array as arguments in 5.7: Added a check to avoid infinite recursion on self-referenced arrays. This fixes #2572