Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Use append instead of add_page #1806

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

neversphere
Copy link
Contributor

@neversphere neversphere commented Apr 22, 2023

Update docs to use append rather than add_page so that the PDF structure is copied. This ensures the form structure is kept which is necessary for some PDFs.

See #1790
Closes #1792
Closes #1804

…ure is copied (which will include the form structure).
@MartinThoma MartinThoma changed the title Update docs to use append rather than add_page so that the pdf structure is copied DOC: Use append instead of add_page Apr 23, 2023
@MartinThoma MartinThoma added the nf-documentation Non-functional change: Documentation label Apr 23, 2023
@MartinThoma MartinThoma merged commit 190b4dc into py-pdf:main Apr 23, 2023
@MartinThoma
Copy link
Member

Thank you!

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html . Just tell me which name I should use and what I should link to (if anything)

@neversphere
Copy link
Contributor Author

neversphere commented Apr 23, 2023 via email

MartinThoma added a commit that referenced this pull request Apr 23, 2023
MartinThoma added a commit that referenced this pull request May 21, 2023
New Features (ENH)
-  Simplify metadata input (Document Information Dictionary) (#1851)
-  Extend cmap compatibilty to GBK_EUC_H/V (#1812)

Bug Fixes (BUG)
-  Prevent infinite loop when no character follows after a comment (#1828)
-  get_contents does not return ContentStream (#1847)
-  Accept XYZ destination with zoom missing (default to zoom=0.0) (#1844)
-  Cope with 1 Bit images (#1815)

Robustness (ROB)
-  Handle missing /Type entry in Page tree (#1845)

Documentation (DOC)
-  Expand file size explanations (#1835)
-  Add comparison with pdfplumber (#1837)
-  Clarify that PyPDF2 is dead (#1827)
-  Add Hunter King as Contributor for #1806

Maintenance (MAINT)
-  Refactor internal Encryption class (#1821)
-  Add R parameter to generate_values (#1820)
-  Make encryption_key parameter of write_to_stream optional (#1819)
-  Prepare for adding AES enryption support (#1818)

Code Style (STY):
-  Iterate directly over the list instead of using range (#1839)
-  Minor refactorings in _encryption.py (#1822)

[Full Changelog](3.8.1...3.9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nf-documentation Non-functional change: Documentation
Projects
None yet
2 participants