Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Refactor Encryption class #1821

Merged
merged 2 commits into from
Apr 30, 2023
Merged

MAINT: Refactor Encryption class #1821

merged 2 commits into from
Apr 30, 2023

Conversation

MartinThoma
Copy link
Member

  • Rename parameters of Encrytpion class
  • Add EncryptMetadata attribute
  • Rename attribute key_size to Length
  • Add P attribute explicitly instead of using "entry"

This makes #1816 smaller

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 96.42% and no project coverage change.

Comparison is base (a2d1e5a) 93.38% compared to head (ebf90e7) 93.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1821   +/-   ##
=======================================
  Coverage   93.38%   93.39%           
=======================================
  Files          34       34           
  Lines        6610     6615    +5     
  Branches     1297     1297           
=======================================
+ Hits         6173     6178    +5     
  Misses        285      285           
  Partials      152      152           
Impacted Files Coverage Δ
pypdf/_encryption.py 91.79% <96.42%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* Rename parameters of Encrytpion class
* Add EncryptMetadata attribute
* Rename attribute key_size to Length
* Add P attribute explicitly instead of using "entry"
* Add values attribute
@MartinThoma MartinThoma merged commit 4504703 into main Apr 30, 2023
@MartinThoma MartinThoma deleted the encryption-class branch April 30, 2023 17:16
MartinThoma added a commit that referenced this pull request May 21, 2023
New Features (ENH)
-  Simplify metadata input (Document Information Dictionary) (#1851)
-  Extend cmap compatibilty to GBK_EUC_H/V (#1812)

Bug Fixes (BUG)
-  Prevent infinite loop when no character follows after a comment (#1828)
-  get_contents does not return ContentStream (#1847)
-  Accept XYZ destination with zoom missing (default to zoom=0.0) (#1844)
-  Cope with 1 Bit images (#1815)

Robustness (ROB)
-  Handle missing /Type entry in Page tree (#1845)

Documentation (DOC)
-  Expand file size explanations (#1835)
-  Add comparison with pdfplumber (#1837)
-  Clarify that PyPDF2 is dead (#1827)
-  Add Hunter King as Contributor for #1806

Maintenance (MAINT)
-  Refactor internal Encryption class (#1821)
-  Add R parameter to generate_values (#1820)
-  Make encryption_key parameter of write_to_stream optional (#1819)
-  Prepare for adding AES enryption support (#1818)

Code Style (STY):
-  Iterate directly over the list instead of using range (#1839)
-  Minor refactorings in _encryption.py (#1822)

[Full Changelog](3.8.1...3.9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant