Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add page deletion feature to PdfWriter #1843

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Conversation

pubpub-zz
Copy link
Collaborator

Delete a page from a pdf

Note : it does not delete the objects from the PDF, just the page entry

@pubpub-zz
Copy link
Collaborator Author

still requires to remove the page from the page access list

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 97.22% and project coverage change: +0.01 🎉

Comparison is base (bd904ea) 93.85% compared to head (ea09d0a) 93.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1843      +/-   ##
==========================================
+ Coverage   93.85%   93.87%   +0.01%     
==========================================
  Files          34       34              
  Lines        6964     7000      +36     
  Branches     1375     1383       +8     
==========================================
+ Hits         6536     6571      +35     
  Misses        282      282              
- Partials      146      147       +1     
Impacted Files Coverage Δ
pypdf/_writer.py 88.61% <ø> (ø)
pypdf/_page.py 93.73% <97.22%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
the codecov report should be positive
all yours (when you will be back from vacations...enjoy😀!)

@MartinThoma MartinThoma changed the title ENH : add page deletion feature ENH: Add page deletion feature Jun 30, 2023
@MartinThoma MartinThoma added the is-feature A feature request label Jun 30, 2023
@MartinThoma MartinThoma changed the title ENH: Add page deletion feature ENH: Add page deletion feature to PdfWriter Jun 30, 2023
@MartinThoma MartinThoma merged commit 115fbfc into py-pdf:main Jun 30, 2023
@MartinThoma
Copy link
Member

Sorry for the delay 🙈

Thank you for the PR and for making it easy for me to merge (having a test + non-breaking change + a single new feature) 🙏

MartinThoma added a commit that referenced this pull request Jul 2, 2023
New Features (ENH):
-  Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938)
-  Add page deletion feature to PdfWriter (#1843)

Bug Fixes (BUG):
-  PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933)
-  Remove unused objects when cloning_from (#1926)
-  Add the TK.SIZE into the trailer (#1911)
-  add_named_destination() maintains named destination list sort order (#1930)
@pubpub-zz pubpub-zz deleted the del_page branch September 2, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is-feature A feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants