Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: add_named_destination() maintains named destination list sort order #1930

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Bug: add_named_destination() maintains named destination list sort order #1930

merged 2 commits into from
Jun 30, 2023

Conversation

robertkearns
Copy link
Contributor

Fixes #1927

MartinThoma
MartinThoma reviewed Jun 30, 2023
View reviewed changes
tests/test_writer.py Outdated Show resolved Hide resolved
@MartinThoma MartinThoma merged commit 014de9b into py-pdf:main Jun 30, 2023
@MartinThoma
Copy link
Member

MartinThoma commented Jun 30, 2023 •
edited
Loading

Thank you for the awesome first contribution 👏 🤗 (issue description + pointing to the PDF specs + PR + test within the PR + "atomic" change which is only about one issue) That was good work!

I just merged it into main. The release of a new version of pypdf to PyPI will happen either tomorrow or on Sunday. Then your change can be used :-)

If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html :-)

MartinThoma added a commit that referenced this pull request Jul 2, 2023
@MartinThoma
REL: 3.12.0
8963a57 
New Features (ENH):
-  Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938)
-  Add page deletion feature to PdfWriter (#1843)

Bug Fixes (BUG):
-  PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933)
-  Remove unused objects when cloning_from (#1926)
-  Add the TK.SIZE into the trailer (#1911)
-  add_named_destination() maintains named destination list sort order (#1930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinThoma MartinThoma MartinThoma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PdfWriter.add_named_destination() does not maintain the name tree sort order
2 participants
@robertkearns @MartinThoma