MAINT: Remove unnecessary property + mypy fixes #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While on it, pre-commit was also updated Taken from #2086 Co-authored-by: Lucas Cimon <925560+Lucas-C@users.noreply.github.com>
|
This seems to give a slight speed boost, but nothing significant. Hence it's not labeled with
nf-performance
|
MartinThoma
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2099 +/- ##
==========================================
- Coverage 94.18% 94.17% -0.01%
==========================================
Files 41 41
Lines 7389 7385 -4
Branches 1459 1459
==========================================
- Hits 6959 6955 -4
Misses 267 267
Partials 163 163
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the property does nothing else than wrapping an attribute, we can use the attribute directly. Once we need the property, we can re-introduce it.
While on it, pre-commit was also updated + the ruff version in CI.
Taken from #2086