MAINT: Reduce usage of b_ #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
==========================================
- Coverage 94.17% 94.16% -0.02%
==========================================
Files 41 41
Lines 7385 7385
Branches 1459 1459
==========================================
- Hits 6955 6954 -1
- Misses 267 268 +1
Partials 163 163
☔ View full report in Codecov by Sentry. |
MartinThoma
commented
Aug 19, 2023
| @@ -820,7 +820,7 @@ def _clone( | |||
|
|
|||
| def hash_value_data(self) -> bytes: | |||
| data = super().hash_value_data() | |||
| data += b_(self._data) | |||
| data += self._data | |||
There was a problem hiding this comment.
That doesn't look quite right for a hash function.
MartinThoma
added
the
soon
MartinThoma
changed the title
MartinThoma
removed
the
soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2099