MAINT: remove unused code

[pubpub-zz]

remove _get_page from reader which is redundant with get_page
faced again some issues with a broken link from tika. Replace them with github links.

[pubpub-zz]

tika files (links are dissapearing progressively):

[stefan6419846]

tika files (links are dissapearing progressively)

Is there any official indication about this?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (0c81f3c) to head (36226e1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2805   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          51       51           
  Lines        8579     8573    -6     
  Branches     1696     1695    -1     
=======================================
- Hits         8223     8218    -5     
  Misses        212      212           
+ Partials      144      143    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pubpub-zz]

(examples_files.yaml)
tika-908104.pdf
tika-923406.pdf
tika-955562.pdf
tika-959173.pdf
tika-957144.pdf
tika-952445.pdf
tika-921632.pdf
tika-976970.pdf
tika-914102.pdf
tika-924546.pdf
tika-972174.pdf
tika-977609.pdf

[pubpub-zz]

tika files (links are dissapearing progressively)

Is there any official indication about this?

No. I've just observer à New linked reported as dead. World you prefer to do it on a dead link report basis?

[stefan6419846]

I tend to prefer this to be done only if there is real need to do so. Additionally, it might make sense as well to review the files before just adding them. There must be reasons why they have been deleted and I am not always sure whether we really need them or whether we could replace them with another one.

[pubpub-zz]

Additionally, it might make sense as well to review the files before just adding them.

All thèse files have been added based on different PRs added for years. @MartinThoma reported them.
Today they provide a good pool of test file

There must be reasons why they have been deleted and I am not always sure whether we really need them or whether we could replace them with another one.

@MartinThoma do you have any idea why links become dead?
Providing replacement is a hudge job. These where reported from a major apache 2.0 project. The licence analysis was for me good enough.