Use qtpy, deprecate superqt.qtcompat, drop support for Qt <5.12 #39
Conversation
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 84.83% 84.55% -0.28%
==========================================
Files 27 24 -3
Lines 2169 2104 -65
==========================================
- Hits 1840 1779 -61
+ Misses 329 325 -4
Continue to review full report at Codecov.
|
|
this still needs spyder-ide/qtpy#276 and spyder-ide/qtpy#271 before we could use qtpy again |
tlambert03
changed the title
tlambert03
changed the title
| @@ -35,6 +35,7 @@ project_urls = | |||
| [options] | |||
| packages = find: | |||
| install_requires = | |||
| qtpy | |||
There was a problem hiding this comment.
add minimal version requirement, Without this update of superqt will not force update of qtpy, so compatibility with PySide6/PyQt6 will be missed.
There was a problem hiding this comment.
Hmmm, I hesitate to do that in case someone wanted to use an older version of qtpy with qt 5.15?
Its not that superqt required 2.0+, it's that PyQt6 does... So it could make some environment resolutions more difficult if we do that.
Thoughts?
There was a problem hiding this comment.
is there release from the time of introduction qtcompat? If yes hen someone may have code that uses superqt, and have an older version of qtpy in the environment, then after the update, the code will be broken. But maybe this is enough small that put information in readme will be enough.
PR that will remove qtcompat and use qtpy again once the qt6 support is realeased.