-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Fix regression in FORCE_QT_API behavior from merging PySide6 support #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, @tlambert03 , thanks! LGTM, aside from the second (EDIT: and third) commit needing a fixup
(and only if @dalthviz would rather not squash-merge it).
I was going to comment on the introduced typo (and clarify the comment a bit), but you fixed the former faster than I could do so, heh.
NB @dalthviz , the second and third commit either needs a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tlambert03 for noticing this and submitting a fix! LGTM 👍
#225 somehow reverted the fix for the broken
FORCE_QT_API
that was fixed in #230. presumably a merge fail... not sure if there are otherson current master (this pretty much destroys environments with multiple Qt backends)