Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove "Setup Boost (macOS)" step #2395

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Aug 14, 2020

Per convo: #2393 (comment) - slows down the macOS builds for very little gain.

@henryiii
Copy link
Collaborator

I miss GitLab's merge when checks pass option. :'(

@EricCousineau-TRI
Copy link
Collaborator Author

Ooh, hadn't seen that in GitLab! But yeah, that would be awesome in cases like these...

@YannickJadoul
Copy link
Collaborator

YannickJadoul commented Aug 14, 2020

We tried out https://github.com/apps/probot-auto-merge on cibuildwheel, at some point. It's ... yeah, a replacement, but there should be a better way.

(For the record; nothing with a minimal amount of approves - really not a fan of setting that up - but just a label to add that will merge on green.)

@henryiii henryiii merged commit 5a3ff72 into pybind:master Aug 14, 2020
@henryiii
Copy link
Collaborator

Did that work well enough?

@YannickJadoul
Copy link
Collaborator

It seems so: pypa/cibuildwheel#383 It worked, but it's maybe a bit weird to have this bot merge it, rather than it just being a feature of the platform...

@bstaletic
Copy link
Collaborator

https://mergify.io/ seems like an alternative to probot-auto-merge.

@henryiii henryiii added the ci related to the CI system label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related to the CI system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants