Skip to content

Renaming PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS to PYBIND11_TYPE_CASTER_BASE_HOLDER. #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2021
Merged

Renaming PYBIND11_SMART_POINTER_HOLDER_TYPE_CASTERS to PYBIND11_TYPE_CASTER_BASE_HOLDER. #2907

merged 1 commit into from
Mar 17, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 17, 2021

Pure renaming for clarity. NO functional changes.

The main motivation for this change is to make the macro name obviously/outstandingly different from PYBIND11_SMART_HOLDER_TYPE_CASTERS, but I think the new name is also even-more fitting, while also not inventing something completely new; it just combines already established names.

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 17, 2021

CI with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT is under #2879

@rwgk
Copy link
Collaborator Author

rwgk commented Mar 17, 2021

@rhaschke The CI is green with and without PYBIND11_USE_SMART_HOLDER_AS_DEFAULT. I will merge this now. I hope you'll only need very trivial changes at your end as well.

@rwgk rwgk merged commit 245d31c into pybind:smart_holder Mar 17, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 17, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Mar 17, 2021
@rwgk rwgk deleted the sh_renaming_to_type_caster_base_holder branch March 17, 2021 12:19
@EricCousineau-TRI EricCousineau-TRI added the smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst label Apr 26, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @EricCousineau-TRI