Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests to exercise disowning combined with multiple inheritance. #2917

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Adding tests to exercise disowning combined with multiple inheritance. #2917

merged 1 commit into from
Mar 23, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 23, 2021

No description provided.

@rwgk rwgk mentioned this pull request Mar 23, 2021
Closed
@rwgk
Copy link
Collaborator Author

rwgk commented Mar 23, 2021

The CI is green, also with PYBIND11_USE_SMART_HOLDER_AS_DEFAULT (#2879). This PR just affects tests, merging now to stay organized. This change will get reviewed internally. I'll open a new PR if there are requests for changes.

@rwgk rwgk marked this pull request as ready for review March 23, 2021 23:24
@rwgk rwgk merged commit eb7b61d into pybind:smart_holder Mar 23, 2021
@rwgk rwgk deleted the test_class_sh_disowning_mi branch March 23, 2021 23:25
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 23, 2021
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Mar 23, 2021
@EricCousineau-TRI EricCousineau-TRI added the smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst label Apr 26, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
smart holder See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @EricCousineau-TRI