-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-dimensional learning rate (sigma0) for AdamW #462
Conversation
…ion tests for multi-dim sigma0's
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #462 +/- ##
===========================================
- Coverage 99.04% 99.03% -0.01%
===========================================
Files 52 52
Lines 3545 3527 -18
===========================================
- Hits 3511 3493 -18
Misses 34 34 ☔ View full report in Codecov by Sentry. |
…ts / odd powers. tests: reduces eis integration coverage, increases test diversity in spm integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. I see that you fixed a few of the cost funtions gradient calculations as well
# Conflicts: # pybop/costs/_likelihoods.py # tests/integration/test_eis_parameterisation.py # tests/integration/test_spm_parameterisations.py
Description
Adds multi-dimensional sigma0 values to AdamW, updates integration tests for multi-dimensional sigma0, and updates the default value in GaussianLogLikehood sigma0
Issue reference
Fixes #461
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.