verification: forbid unsupported NCs #10570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rather than silently ignoring them. Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
|
Do we only want to reject matching pairs, or reject all validations with an other name constraint? |
I think just matching pairs: RFC 5280 says that NCs only need to be evaluated if a subject of the name form appears, so rejecting any cert that has an OtherName NC could (in practice, unlikely) prematurely exclude certs/chains that don't actually have any OtherName SANs. |
|
I suppose that means I should add a testcase for "validator doesn't reject chain with an OtherName constraint when there's no OtherName SANs" 🙂 Edit: C2SP/x509-limbo#229 |
|
Ok, makes sense, and yeah always test cases are good.
…On Mon, Mar 11, 2024, 5:30 PM William Woodruff ***@***.***> wrote:
I suppose that means I should add a testcase for "validator doesn't reject
chain with an OtherName constraint when there's no OtherName SANs" 🙂
—
Reply to this email directly, view it on GitHub
<#10570 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBAIXD4AVIU6FTKJB6DYXYV7PAVCNFSM6AAAAABERCE27CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGQ3TSNBQHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Signed-off-by: William Woodruff <william@yossarian.net>
|
Merged both new testcases and the CI is green, so this should be good to go 🙂 |
alex
approved these changes
Mar 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than silently ignoring them.
Needs coverage, which I'll add with C2SP/x509-limbo#228 once I merge that.